Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download cURL in older Linux containers on binary build #275

Merged
merged 1 commit into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
build-lint-test:
strategy:
fail-fast: true
fail-fast: false
matrix:
os: [ubuntu-latest, ubuntu-arm, macos-intel, macos-arm, windows-latest]
include:
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
build-bridge-libraries:
strategy:
fail-fast: true
fail-fast: false
matrix:
os: [ubuntu-latest, ubuntu-arm, macos-intel, macos-arm, windows-latest]
include:
Expand All @@ -18,13 +18,15 @@ jobs:
# We use the Python manylinux image for glibc compatibility
container: quay.io/pypa/manylinux2014_x86_64
protobuf-url: https://github.com/protocolbuffers/protobuf/releases/download/v22.3/protoc-22.3-linux-x86_64.zip
curl-download: https://github.com/stunnel/static-curl/releases/download/8.8.0/curl-linux-x86_64-8.8.0.tar.xz
- os: ubuntu-arm
out-file: libtemporal_sdk_bridge.so
out-prefix: linux-arm64
runsOn: buildjet-4vcpu-ubuntu-2204-arm
# We use the Python manylinux image for glibc compatibility
container: quay.io/pypa/manylinux2014_aarch64
protobuf-url: https://github.com/protocolbuffers/protobuf/releases/download/v22.3/protoc-22.3-linux-aarch_64.zip
curl-download: https://github.com/stunnel/static-curl/releases/download/8.8.0/curl-linux-aarch64-8.8.0.tar.xz
- os: macos-intel
out-file: libtemporal_sdk_bridge.dylib
out-prefix: osx-x64
Expand All @@ -51,6 +53,13 @@ jobs:
with:
submodules: recursive

# Need to update cURL on Linux for the Rust install step
- name: Update cURL
if: ${{ matrix.curl-download }}
run: |
curl --fail -L "${{ matrix.curl-download }}" -o curl.tar.xz
tar -xJvf curl.tar.xz -C /usr/local/bin

- name: Install Rust
uses: dtolnay/rust-toolchain@stable
with:
Expand Down