Allow updating search attributes from schedule updates #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked at the Go impl while doing this and I think the language here needs to be changed: https://github.com/temporalio/sdk-go/pull/1562/files#diff-03e17ff1d7fdefff7ba8a41ea26b6f3a3135e4b084e58cef60574e60bfd9a9f2R493 It is distinctly not an upsert operation. It is straight-up replacement. An upsert would preserve unchanged attributes if they are not included in the new collection, but they are wiped out unless you manually copy the existing attributes. |
Sushisource
commented
Aug 3, 2024
| @@ -54,14 +54,6 @@ pub struct ForwardedLog { | |||
| fields_json: Arc<Mutex<Option<String>>>, | |||
| } | |||
|
|
|||
| #[repr(C)] | |||
| pub struct ForwardedLogDetails { | |||
Sushisource
force-pushed
the
sched-update-sas
branch
from
a327e02 to
13e8650
Compare
|
Yeah would be in favor of fixing the Go SDK docs as well |
cretz
reviewed
Aug 5, 2024
cretz
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added ability to update the SAs for schedules
Also updated Core, largely to eliminate some compiler warnings from new Rust version
Why?
Parity
Checklist
Closes [Feature Request] Support schedule search attribute update #314
How was this tested:
Added tests
Any docs updates needed?