Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BasicAuth bug in HttpConnectProxyOptions.ToInteropOptions() #334

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Fix BasicAuth bug in HttpConnectProxyOptions.ToInteropOptions() #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0b4edb
Align all 'host:port' strings
adeal Aug 24, 2024
7da8887
Use options.BasicAuth?.Password
adeal Aug 24, 2024
e1e0cd7
sync submodule
adeal Aug 24, 2024
4de104c
Merge branch 'main' into dev/adeal/ClientHttpConnectProxyOptions_bugfix
adeal Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Temporalio/Bridge/EphemeralServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ private unsafe EphemeralServer(
public override unsafe bool IsInvalid => ptr == null;

/// <summary>
/// Gets the target host:port of the server.
/// Gets the target <c>host:port</c> of the server.
/// </summary>
public string Target { get; private init; }

Expand Down
2 changes: 1 addition & 1 deletion src/Temporalio/Bridge/OptionsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ public static Interop.ClientHttpConnectProxyOptions ToInteropOptions(
{
target_host = scope.ByteArray(options.TargetHost),
username = scope.ByteArray(options.BasicAuth?.Username),
password = scope.ByteArray(options.BasicAuth?.Username),
password = scope.ByteArray(options.BasicAuth?.Password),
};
}

Expand Down
4 changes: 2 additions & 2 deletions src/Temporalio/Client/HttpConnectProxyOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ public HttpConnectProxyOptions()
/// <summary>
/// Initializes a new instance of the <see cref="HttpConnectProxyOptions"/> class.
/// </summary>
/// <param name="targetHost">A 'host:port' string representing the target to proxy through.</param>
/// <param name="targetHost">A <c>host:port</c> string representing the target to proxy through.</param>
public HttpConnectProxyOptions(string targetHost) => TargetHost = targetHost;

/// <summary>
/// Gets or sets the target host to proxy through as a host:port string.
/// Gets or sets the target host to proxy through as a <c>host:port</c> string.
/// </summary>
/// <remarks>
/// This is required for all proxy options.
Expand Down
Loading