Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly clear metadata when encoding/decoding payloads #343

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Properly clear metadata when encoding/decoding payloads #343

merged 2 commits into from
Sep 5, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Sep 4, 2024

What was changed

Properly cleared out Data on payload before merging (i.e. replacing) inline.

Checklist

  1. Closes [Bug] Payload data not properly cleared before replaced #342

@cretz cretz requested a review from a team September 4, 2024 13:19
@cretz cretz merged commit ec8821d into temporalio:main Sep 5, 2024
8 checks passed
@cretz cretz deleted the payload-null-fix branch September 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Payload data not properly cleared before replaced
2 participants
@cretz @Quinn-With-Two-Ns