Skip to content

Commit

Permalink
Remove 3.7 support (and other build/README things)
Browse files Browse the repository at this point in the history
  • Loading branch information
cretz committed Nov 9, 2023
1 parent 4e0883e commit f5d0bab
Show file tree
Hide file tree
Showing 12 changed files with 232 additions and 169 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/build-binaries.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
name: Build Binaries
on:
# TODO(cretz): Remove
pull_request:
push:
branches:
- main
Expand Down Expand Up @@ -32,11 +34,11 @@ jobs:
- if: ${{ !endsWith(matrix.os, '-arm') }}
uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"
- if: ${{ matrix.os == 'ubuntu-arm' }}
uses: deadsnakes/[email protected]
with:
python-version: "3.11"
python-version: "3.12"

# Install Rust locally for non-Linux (Linux uses an internal docker
# command to build with cibuildwheel which uses rustup install defined
Expand All @@ -55,7 +57,7 @@ jobs:
# https://github.com/python-poetry/poetry/issues/7611 and
# https://github.com/python-poetry/poetry/pull/7694 are fixed
- run: python -m pip install --upgrade wheel "poetry==1.3.2" poethepoet
- run: poetry install --no-root -E opentelemetry
- run: poetry install --no-root --all-extras

# Add the source dist only for Linux x64 for now
- if: ${{ matrix.package-suffix == 'linux-amd64' }}
Expand Down
12 changes: 5 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ jobs:
strategy:
fail-fast: true
matrix:
python: ["3.7", "3.11"]
python: ["3.8", "3.12"]
os: [ubuntu-latest, macos-latest, windows-latest, ubuntu-arm]
include:
- os: ubuntu-latest
python: "3.11"
python: "3.12"
docsTarget: true
- os: ubuntu-latest
python: "3.7"
python: "3.8"
protoCheckTarget: true
- os: ubuntu-arm
runsOn: buildjet-4vcpu-ubuntu-2204-arm
Expand All @@ -44,9 +44,7 @@ jobs:
- if: ${{ !endsWith(matrix.os, '-arm') }}
uses: actions/setup-python@v4
with:
# Due to a yet-uninvestigated change in 3.11.6 that breaks the Rust
# linker on Windows, we are pinning 3.11 to 3.11.5 here
python-version: ${{ matrix.python == '3.11' && '3.11.5' || matrix.python }}
python-version: ${{ matrix.python }}
- if: ${{ matrix.os == 'ubuntu-arm' }}
uses: deadsnakes/[email protected]
with:
Expand All @@ -55,7 +53,7 @@ jobs:
# https://github.com/python-poetry/poetry/issues/7611 and
# https://github.com/python-poetry/poetry/pull/7694 are fixed
- run: python -m pip install --upgrade wheel "poetry==1.3.2" poethepoet
- run: poetry install --no-root -E opentelemetry
- run: poetry install --no-root --all-extras
- run: poe lint
- run: poe build-develop
- run: poe test -s -o log_cli_level=DEBUG
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/run-bench.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
name: Run Bench
on:
# TODO(cretz): Remove
pull_request:
workflow_call:
inputs:
sandbox-arg:
Expand Down Expand Up @@ -37,11 +39,11 @@ jobs:
working-directory: temporalio/bridge
- uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"

# Build
- run: python -m pip install --upgrade wheel poetry poethepoet
- run: poetry install --no-root -E opentelemetry
- run: poetry install --no-root --all-extras
- run: poe build-develop-with-release

# Run a bunch of bench tests. We run multiple times since results vary.
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
![Temporal Python SDK](https://assets.temporal.io/w/py-banner.svg)

[![Python 3.7+](https://img.shields.io/pypi/pyversions/temporalio.svg?style=for-the-badge)](https://pypi.org/project/temporalio)
[![Python 3.8+](https://img.shields.io/pypi/pyversions/temporalio.svg?style=for-the-badge)](https://pypi.org/project/temporalio)
[![PyPI](https://img.shields.io/pypi/v/temporalio.svg?style=for-the-badge)](https://pypi.org/project/temporalio)
[![MIT](https://img.shields.io/pypi/l/temporalio.svg?style=for-the-badge)](LICENSE)

Expand Down Expand Up @@ -1295,7 +1295,7 @@ users are encouraged to not use gevent in asyncio applications (including Tempor

# Development

The Python SDK is built to work with Python 3.7 and newer. It is built using
The Python SDK is built to work with Python 3.8 and newer. It is built using
[SDK Core](https://github.com/temporalio/sdk-core/) which is written in Rust.

### Building
Expand All @@ -1304,7 +1304,7 @@ The Python SDK is built to work with Python 3.7 and newer. It is built using

To build the SDK from source for use as a dependency, the following prerequisites are required:

* [Python](https://www.python.org/) >= 3.7
* [Python](https://www.python.org/) >= 3.8
* [Rust](https://www.rust-lang.org/)
* [poetry](https://github.com/python-poetry/poetry) (e.g. `python -m pip install poetry`)
* [poe](https://github.com/nat-n/poethepoet) (e.g. `python -m pip install poethepoet`)
Expand Down
2 changes: 1 addition & 1 deletion build.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def build(setup_kwargs):
path="temporalio/bridge/Cargo.toml",
binding=Binding.PyO3,
py_limited_api=True,
features=["pyo3/abi3-py37"],
features=["pyo3/abi3-py38"],
)
],
zip_safe=False,
Expand Down
Loading

0 comments on commit f5d0bab

Please sign in to comment.