Update core and release version #314
Conversation
| async def test_workflow_patch_memoized(client: Client): | ||
| # TODO(cretz): Patches have issues on older servers since core needs patch | ||
| # metadata support for some fixes. Unskip for local server only once we | ||
| # upgrade to https://github.com/temporalio/sdk-python/issues/272. | ||
| pytest.skip("Needs SDK metadata support") |
There was a problem hiding this comment.
@Sushisource - I was getting similar issues here as I was with .NET on querying during patch workflows. Here's a CI log snippet:
RuntimeError: Missing start workflow, workflow could have unexpectedly been removed from cache
2023-04-28T14:26:00.938272Z WARN temporal_sdk_core::worker::workflow: Failing legacy query request run_id=0496c65c-616f-40b1-983f-eae49114d7df failure=Failure { failure: Some(Failure { message: "Missing start workflow, workflow could have unexpectedly been removed from cache", source: "", stack_trace: " File \"/home/runner/work/sdk-python/sdk-python/temporalio/worker/_workflow.py\", line 190, in _handle_activation\n workflow = self._create_workflow_instance(act)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n File \"/home/runner/work/sdk-python/sdk-python/temporalio/worker/_workflow.py\", line 288, in _create_workflow_instance\n raise RuntimeError(\n", encoded_attributes: None, cause: None, failure_info: Some(ApplicationFailureInfo(ApplicationFailureInfo { r#type: "RuntimeError", non_retryable: false, details: None })) }), force_cause: Unspecified }
I assume this is due to the server version we're using not supporting internal flags, so I skipped this test the same as I did the .NET one. I may have misdiagnosed and it was a fluke test because I can't break locally. May be worth investigating.
There was a problem hiding this comment.
1.20 has sdk metadata support.
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "temporalio" | |||
| version = "1.1.0" | |||
| version = "1.2.0" | |||
There was a problem hiding this comment.
Why do a minor instead of a patch?
There was a problem hiding this comment.
Is it due to behavior changes in Core?
There was a problem hiding this comment.
In general, for the SDK releases I've found always assuming minor except for emergency hotfixes makes for a clearer stream of releases. Last release was over two months ago, so this can be a standard release IMO (there just aren't enough features to have a regular release cadence). But for the pure definition of semver, this and the other things done in the last two months are technically a patch. If a minor is bothersome enough I can change it.
What was changed
Update core for some critical updates and set a new release version in preparation for a new release