Wait for activity completions on worker shutdown #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
force-pushed
the
wait-activity-completions
branch
from
a9e4534 to
60257db
Compare
Sushisource
approved these changes
Aug 21, 2023
|
Sure, opened temporalio/sdk-core#594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
On shutdown, wait on all activities to complete including their completion futures to core. In core, shutdown may complete but calls to server may still be outstanding. So in the case of #368 where the process was killed when shutdown completed, the completion may have happened but not flushed causing server to not get the completion.
There is no good/easy way to test the internal core difference between activity completion sent and activity completion flushed.
Checklist