Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core/tonic, update metric options, remove core tracing #380

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Update core/tonic, update metric options, remove core tracing #380

merged 2 commits into from
Aug 31, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Aug 25, 2023

What was changed

  • Update core
  • Update cargo deps including bumping tonic to 0.9
  • Update Rust bridge to adopt new metric instantiation
  • Add missing metrics options
  • 💥 BREAKING CHANGE - Removed temporalio.runtime.TelemetryConfig.tracing and associated class
    • This is only for advanced internal support for core tracing which wasn't really used anyways

Checklist

  1. Closes [Bug] mTLS doesn't support non-EC private keys #371

@cretz cretz requested a review from a team as a code owner August 25, 2023 14:56
Quinn-With-Two-Ns
Quinn-With-Two-Ns reviewed Aug 28, 2023
View reviewed changes
temporalio/bridge/src/runtime.rs
@@ -27,16 +29,8 @@ pub(crate) struct Runtime {

#[derive(FromPyObject)]
pub struct TelemetryConfig {
tracing: Option<TracingConfig>,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we are removing rather then say deprecating an treating it as unused?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as part of temporalio/sdk-core#599 which didn't work anyways and, based on internal discussions, was a rarely used advanced core debug tracer that we wanted to remove instead of deprecate.

@mjameswh mjameswh mentioned this pull request Aug 29, 2023
Open
@cretz cretz merged commit aa829d3 into temporalio:main Aug 31, 2023
@cretz cretz deleted the core-update3 branch August 31, 2023 14:09
@cretz cretz mentioned this pull request Sep 7, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] mTLS doesn't support non-EC private keys
3 participants
@cretz @Sushisource @Quinn-With-Two-Ns