Start requiring pyright typechecking #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
pyright
branch
2 times, most recently
from
5742b1e to
7dcfbda
Compare
cretz
approved these changes
Aug 26, 2024
| @@ -174,6 +176,41 @@ privacy = [ | |||
| project-name = "Temporal Python" | |||
| sidebar-expand-depth = 2 | |||
|
|
|||
| [tool.pyright] | |||
There was a problem hiding this comment.
That's a lot of excluded files. Are we sure we don't want to solve even some of them here?
There was a problem hiding this comment.
Yes, I'd like to keep this PR focused on the infrastructure, and subsequent PRs focused on actual type checking considerations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #420
Start requiring
pyrightto pass inpoe lint/ CI. At this commit it passes because some files are excluded. Subsequent PRs will fix pyright type violations in files and reduce the exclusion list.