Update Core / InitializeWorkflow #683
Conversation
Sushisource
force-pushed
the
core-update
branch
from
000ce72 to
1331902
Compare
There was a problem hiding this comment.
LGTM, just one ordering confirmation. Would also like @dandavison to look.
| @@ -354,8 +354,8 @@ def activate( | |||
| elif job.HasField("signal_workflow") or job.HasField("do_update"): | |||
| job_sets[1].append(job) | |||
| elif not job.HasField("query_workflow"): | |||
| if job.HasField("start_workflow"): | |||
| start_job = job.start_workflow | |||
| if job.HasField("initialize_workflow"): | |||
There was a problem hiding this comment.
We changed the order this item appears in the activation job list, correct? Can you confirm that that will have no effect here because of the built in Python ordering already present here?
There was a problem hiding this comment.
Yeah, it doesn't matter because everything gets reordered anyway
There was a problem hiding this comment.
Please wait for @dandavison approval as well on this one, want him to make sure he doesn't see any issues.
There was a problem hiding this comment.
LGTM too. I can't see how temporalio/sdk-core@5462522 would change Python behavior given the lang-level control over job ordering.
What was changed
Update core & handle start workflow rename. This just deals with the rename, it does not attempt to use the new job application scheme discussed in #606
Why?
Need Core updates
Checklist
Closes
How was this tested:
Existing tests
Any docs updates needed?