Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose http option for OTLP #741

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Expose http option for OTLP #741

merged 1 commit into from
Jan 23, 2025

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Jan 21, 2025

Tested using

docker run \
  -p 127.0.0.1:4317:4317 \
  -p 127.0.0.1:4318:4318 \
  -p 127.0.0.1:55679:55679 \
  otel/opentelemetry-collector-contrib:0.118.0

and running https://github.com/temporalio/samples-python/blob/main/open_telemetry/README.md

using

    Runtime(
        telemetry=TelemetryConfig(
            metrics=OpenTelemetryConfig(
                url="http://localhost:4318/v1/metrics", http=True
            )
        )
    )

@dandavison dandavison marked this pull request as ready for review January 23, 2025 21:37
@dandavison dandavison requested a review from a team as a code owner January 23, 2025 21:37
),
metric_temporality_delta=(
self.metric_temporality == OpenTelemetryMetricTemporality.DELTA
),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ just prettifying the formatting

@yuandrew
Copy link
Contributor

For my own understanding, where is this set?

Runtime(
        telemetry=TelemetryConfig(
            metrics=OpenTelemetryConfig(
                url="http://localhost:4318/v1/metrics", http=True
            )
        )
    )

@dandavison
Copy link
Contributor Author

For my own understanding, where is this set?

In the worker config in this sample: https://github.com/temporalio/samples-python/blob/main/open_telemetry/worker.py#L43

@yuandrew
Copy link
Contributor

Ahh, thanks, I missed that when scanning through the files

@dandavison dandavison merged commit 45aa3a2 into main Jan 23, 2025
14 checks passed
@dandavison dandavison deleted the otlp-http branch January 23, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants