Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some lint errors #744

Merged
merged 1 commit into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions temporalio/worker/_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ async def run(self) -> None:

def notify_shutdown(self) -> None:
if self._could_not_evict_count:
logger.warn(
logger.warning(
f"Shutting down workflow worker, but {self._could_not_evict_count} "
+ "workflow(s) could not be evicted previously, so the shutdown will hang"
)
Expand Down Expand Up @@ -244,7 +244,9 @@ async def _handle_activation(
self._running_workflows[act.run_id] = workflow
elif init_job:
# This should never happen
logger.warn("Cache already exists for activation with initialize job")
logger.warning(
"Cache already exists for activation with initialize job"
)

# Run activation in separate thread so we can check if it's
# deadlocked
Expand Down
2 changes: 1 addition & 1 deletion tests/helpers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import uuid
from contextlib import closing
from datetime import timedelta
from typing import Any, Awaitable, Callable, Optional, Sequence, Type, TypeVar
from typing import Awaitable, Callable, Optional, Sequence, Type, TypeVar

from temporalio.api.common.v1 import WorkflowExecution
from temporalio.api.enums.v1 import IndexedValueType
Expand Down
Loading