Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace v1 base with restfly #457

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

SteveMcGrath
Copy link
Contributor

Description

Addresses depreciation of pyTenable's v1 connection library and transitions that connection logic to the RESTfly library instead.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    1. This could break existing code that leverages specific Exception handling.
  • This change requires a documentation update
    1. Documentation would need to be updated around exception handling.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local testing with py.test
  • Local testing against python matrix using act.

Test Configuration:

  • Python Version(s) Tested: 3.6, 3.7, 3.8, 3.9
  • Tenable.sc version (if necessary): 3.18

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team October 25, 2021 22:04
Reworked pipeline to use bare setup instead.

Refactored out most of base/v1 to use RESTfly

Pipeline update

Updated Tenable.sc docs & updated .snyk file.
Copy link
Contributor

@nkeuning nkeuning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

@SteveMcGrath SteveMcGrath merged commit 5157e06 into master Oct 26, 2021
@SteveMcGrath SteveMcGrath deleted the replace-v1-base-w-restfly branch October 26, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants