Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of Mul/Quo and Mul/QuoTruncate #413

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

hallazzang
Copy link
Contributor

Description

  • use Mul/Quo for pool price(reserve ratio)
  • use *Truncate for minting pool coin amount

closes: #380


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang hallazzang self-assigned this Jun 14, 2021
@hallazzang hallazzang force-pushed the 380-mul-quo-truncate branch from 26c6b70 to 5948d0b Compare June 14, 2021 08:01
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #413 (5948d0b) into develop (2a38c43) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #413   +/-   ##
========================================
  Coverage    83.45%   83.45%           
========================================
  Files           20       20           
  Lines         2278     2278           
========================================
  Hits          1901     1901           
  Misses         215      215           
  Partials       162      162           
Impacted Files Coverage Δ
x/liquidity/keeper/liquidity_pool.go 82.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a38c43...5948d0b. Read the comment docs.

@hallazzang hallazzang requested a review from dongsam June 15, 2021 03:09
@hallazzang hallazzang marked this pull request as ready for review June 15, 2021 03:09
@dongsam dongsam merged commit 21b49d5 into tendermint:develop Jun 15, 2021
@hallazzang hallazzang deleted the 380-mul-quo-truncate branch June 15, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide where to use Quo/MulTruncate and where to use Quo/Mul
2 participants