Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

RFC-001: configurable block retention #84

Merged
merged 15 commits into from
Apr 2, 2020
Merged

RFC-001: configurable block retention #84

merged 15 commits into from
Apr 2, 2020

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Mar 23, 2020

@tac0turtle tac0turtle requested a review from melekes March 23, 2020 19:20
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd vote for adding explicit checks to Cosmos SDK to prevent misconfiguration.

@erikgrinaker
Copy link
Contributor Author

I'd vote for adding explicit checks to Cosmos SDK to prevent misconfiguration.

I've added some enforced checks and made a few other changes. Will give others a chance to review as well.

@erikgrinaker
Copy link
Contributor Author

@alexanderbez @ebuchman @brapse Do you have any opinions on this?

rfc/001-truncated-block-history.md Outdated Show resolved Hide resolved
rfc/001-truncated-block-history.md Outdated Show resolved Hide resolved
rfc/001-truncated-block-history.md Outdated Show resolved Hide resolved
rfc/001-truncated-block-history.md Outdated Show resolved Hide resolved
rfc/001-truncated-block-history.md Outdated Show resolved Hide resolved
rfc/001-truncated-block-history.md Outdated Show resolved Hide resolved
rfc/001-truncated-block-history.md Outdated Show resolved Hide resolved
@erikgrinaker erikgrinaker changed the title RFC: truncated block history coordination RFC: configurable block retention Mar 31, 2020
rfc/001-block-retention.md Outdated Show resolved Hide resolved
rfc/001-block-retention.md Outdated Show resolved Hide resolved
@erikgrinaker erikgrinaker changed the title RFC: configurable block retention RFC-001: configurable block retention Apr 2, 2020
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tac0turtle tac0turtle merged commit 3ab6026 into tendermint:master Apr 2, 2020
@erikgrinaker erikgrinaker deleted the erik/truncated-block-history branch April 2, 2020 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants