This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
RFC-001: configurable block retention #84
Merged
tac0turtle
merged 15 commits into
tendermint:master
from
erikgrinaker:erik/truncated-block-history
Apr 2, 2020
Merged
RFC-001: configurable block retention #84
tac0turtle
merged 15 commits into
tendermint:master
from
erikgrinaker:erik/truncated-block-history
Apr 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
requested review from
josef-widder,
konnov and
milosevic
as code owners
March 23, 2020 18:09
This was referenced Mar 23, 2020
melekes
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd vote for adding explicit checks to Cosmos SDK to prevent misconfiguration.
…some minor tweaks
I've added some enforced checks and made a few other changes. Will give others a chance to review as well. |
@alexanderbez @ebuchman @brapse Do you have any opinions on this? |
4 tasks
zmanian
reviewed
Mar 26, 2020
tac0turtle
reviewed
Mar 26, 2020
erikgrinaker
changed the title
RFC: truncated block history coordination
RFC: configurable block retention
Mar 31, 2020
melekes
reviewed
Apr 1, 2020
melekes
approved these changes
Apr 2, 2020
erikgrinaker
changed the title
RFC: configurable block retention
RFC-001: configurable block retention
Apr 2, 2020
4 tasks
tac0turtle
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: https://github.com/tendermint/spec/blob/master/rfc/001-block-retention.md