Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

document state sync ABCI interface and P2P protocol #90

Merged
merged 7 commits into from
May 5, 2020
Merged

document state sync ABCI interface and P2P protocol #90

merged 7 commits into from
May 5, 2020

Conversation

erikgrinaker
Copy link
Contributor

The corresponding Tendermint PRs are tendermint/tendermint#4704 and tendermint/tendermint#4705.

We should probably add a guide that reads more like a hands-on tutorial as well, with actual commands and examples. I'll write this as part of the release package.

spec/abci/abci.md Show resolved Hide resolved
spec/abci/apps.md Show resolved Hide resolved
spec/reactors/state_sync/reactor.md Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! The documented changes were very easy to follow. I left a few minor questions 👍

spec/abci/abci.md Show resolved Hide resolved
spec/abci/abci.md Outdated Show resolved Hide resolved
spec/abci/abci.md Show resolved Hide resolved
spec/abci/abci.md Show resolved Hide resolved
spec/abci/apps.md Show resolved Hide resolved
spec/abci/apps.md Show resolved Hide resolved
spec/abci/apps.md Outdated Show resolved Hide resolved
spec/abci/apps.md Show resolved Hide resolved
spec/abci/apps.md Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tessr tessr merged commit 9842b4b into tendermint:master May 5, 2020
tessr added a commit that referenced this pull request May 5, 2020
tessr added a commit that referenced this pull request May 5, 2020
tessr added a commit that referenced this pull request May 5, 2020
melekes pushed a commit that referenced this pull request May 11, 2020
* Revert "Revert "document state sync ABCI interface and P2P protocol (#90)" (#92)"

This reverts commit 90797ce.

* update with new enum case

* fix links

Co-authored-by: Erik Grinaker <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants