Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(campaign): emit events #750

Merged
merged 12 commits into from
May 9, 2022
Merged

feat(campaign): emit events #750

merged 12 commits into from
May 9, 2022

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Apr 27, 2022

Closes #428

What does this PR does?

Matthews3301 please review :)

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #750 (1780840) into develop (ff51a17) will decrease coverage by 0.23%.
The diff coverage is 5.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #750      +/-   ##
===========================================
- Coverage    11.27%   11.04%   -0.24%     
===========================================
  Files          281      282       +1     
  Lines        64146    66452    +2306     
===========================================
+ Hits          7233     7338     +105     
- Misses       56742    58940    +2198     
- Partials       171      174       +3     
Impacted Files Coverage Δ
x/campaign/types/events.pb.go 0.54% <0.54%> (ø)
x/campaign/keeper/msg_add_shares.go 77.77% <53.57%> (-15.84%) ⬇️
x/campaign/keeper/msg_unredeem_vouchers.go 63.15% <53.84%> (-3.51%) ⬇️
x/campaign/keeper/msg_add_vesting_options.go 82.14% <100.00%> (+7.14%) ⬆️
x/campaign/keeper/msg_burn_vouchers.go 72.72% <100.00%> (+4.87%) ⬆️
x/campaign/keeper/msg_create_campaign.go 84.21% <100.00%> (+2.39%) ⬆️
x/campaign/keeper/msg_edit_campaign.go 100.00% <100.00%> (ø)
x/campaign/keeper/msg_initialize_mainnet.go 94.23% <100.00%> (+0.75%) ⬆️
x/campaign/keeper/msg_mint_vouchers.go 73.33% <100.00%> (+4.91%) ⬆️
x/campaign/keeper/msg_redeem_vouchers.go 89.65% <100.00%> (+3.29%) ⬆️
... and 3 more

proto/campaign/events.proto Show resolved Hide resolved
x/campaign/keeper/msg_redeem_vouchers.go Outdated Show resolved Hide resolved
proto/campaign/events.proto Show resolved Hide resolved
x/campaign/keeper/msg_add_shares.go Outdated Show resolved Hide resolved
x/campaign/keeper/msg_add_vesting_options.go Outdated Show resolved Hide resolved
@aljo242 aljo242 requested a review from lumtis April 27, 2022 15:22
Matthews3301
Matthews3301 previously approved these changes Apr 29, 2022
@giunatale giunatale merged commit 100c166 into develop May 9, 2022
@giunatale giunatale deleted the feat/campaign-events branch May 9, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate on Event emitting for campaign
4 participants