Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reward): emit events #752

Merged
merged 14 commits into from
May 11, 2022
Merged

feat(reward): emit events #752

merged 14 commits into from
May 11, 2022

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Apr 27, 2022

Closes #732

Emits events for Create, Update, Remove actions on the RewardPool type. Additionally emits EventRewardsDistributed during k.DistributeRewards().

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #752 (8ce640b) into develop (045c15b) will decrease coverage by 0.07%.
The diff coverage is 3.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #752      +/-   ##
===========================================
- Coverage    10.99%   10.92%   -0.08%     
===========================================
  Files          284      285       +1     
  Lines        66878    67488     +610     
===========================================
+ Hits          7356     7372      +16     
- Misses       59347    59940     +593     
- Partials       175      176       +1     
Impacted Files Coverage Δ
x/reward/types/events.pb.go 0.83% <0.83%> (ø)
x/reward/keeper/reward_distribution.go 80.57% <62.50%> (-1.11%) ⬇️
x/reward/keeper/msg_set_reward.go 93.02% <100.00%> (+0.52%) ⬆️

x/reward/keeper/msg_set_reward.go Outdated Show resolved Hide resolved
x/reward/keeper/reward_distribution.go Outdated Show resolved Hide resolved
x/reward/keeper/reward_distribution.go Outdated Show resolved Hide resolved
@aljo242 aljo242 requested a review from lumtis May 9, 2022 17:51
x/reward/keeper/msg_set_reward.go Outdated Show resolved Hide resolved
x/reward/keeper/msg_set_reward.go Outdated Show resolved Hide resolved
@giunatale giunatale merged commit c1b42d0 into develop May 11, 2022
@giunatale giunatale deleted the feat/reward-events branch May 11, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement events for reward
3 participants