Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove SendVoucher operation in simulation #760

Merged
merged 2 commits into from
May 5, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented May 4, 2022

Remove it since bank simulation perform sending coins operation

@lumtis lumtis linked an issue May 4, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #760 (f62f9d1) into develop (de73982) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #760   +/-   ##
========================================
  Coverage    11.15%   11.16%           
========================================
  Files          281      281           
  Lines        63663    63642   -21     
========================================
  Hits          7103     7103           
+ Misses       56397    56376   -21     
  Partials       163      163           
Impacted Files Coverage Δ
x/campaign/simulation/simulation.go 0.00% <ø> (ø)

Copy link
Contributor

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@lumtis lumtis merged commit 096ed50 into develop May 5, 2022
@lumtis lumtis deleted the test/remove-msg-send-vouchers branch May 5, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MsgSendVouchers operation in simulation
2 participants