refactor(launch): remove Chain struct from events
#776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2022 13:46
aljo242
requested review from
fadeev,
ilgooz,
lumtis,
Pantani,
ivanovpetr and
giunatale
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #776 +/- ##
===========================================
- Coverage 11.00% 11.00% -0.01%
===========================================
Files 284 284
Lines 66916 66878 -38
===========================================
- Hits 7363 7358 -5
+ Misses 59379 59346 -33
Partials 174 174
|
lumtis
approved these changes
May 9, 2022
giunatale
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #775
What does this PR does?
Chainstruct fromlauncheventsEventChainUpdatedcampaign|EventCampaignChainAdded. This event lets us emit extra info about campaign-chain associations in a more lightweight way.