Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(profile): simplify events #791

Merged
merged 4 commits into from
May 13, 2022

Conversation

aljo242
Copy link

@aljo242 aljo242 commented May 11, 2022

Closes #787

Emit more specific update events like EventCoordinatorDisabled instead of EventCoordinatorUpdated.

  • We no longer emit events when only metadata is changed (coordinator and validator descriptions, etc.)

@aljo242 aljo242 changed the title Refactor/simplify profile events refactor(profile): simplify events May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #791 (9f68480) into develop (1282178) will decrease coverage by 0.05%.
The diff coverage is 6.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #791      +/-   ##
===========================================
- Coverage    10.86%   10.81%   -0.06%     
===========================================
  Files          286      286              
  Lines        67946    68267     +321     
===========================================
- Hits          7385     7384       -1     
- Misses       60386    60707     +321     
- Partials       175      176       +1     
Impacted Files Coverage Δ
x/profile/types/events.pb.go 0.72% <0.67%> (-0.21%) ⬇️
...ofile/keeper/msg_add_validator_operator_address.go 100.00% <100.00%> (ø)
x/profile/keeper/msg_create_coordinator.go 100.00% <100.00%> (ø)
x/profile/keeper/msg_disable_coordinator.go 67.74% <100.00%> (+1.07%) ⬆️
x/profile/keeper/msg_update_coordinator_address.go 75.60% <100.00%> (+1.25%) ⬆️
...ofile/keeper/msg_update_coordinator_description.go 68.75% <100.00%> (-2.68%) ⬇️
...profile/keeper/msg_update_validator_description.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 81.08% <0.00%> (-1.36%) ⬇️

@giunatale giunatale merged commit cd0cfc7 into develop May 13, 2022
@giunatale giunatale deleted the refactor/simplify-profile-events branch May 13, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove structs from profile events
3 participants