Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(campaign): implement query special-allocations-balance #802

Merged
merged 9 commits into from
May 27, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented May 17, 2022

special-allocations-balance get the final token balance for special allocation.

This query is to be used by the client to verify the genesis is correctly formatted:

bank:
 supply == genesisDistribution
claim:
 airdropSupply == claimableAirdrop

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #802 (6fb0761) into develop (11fb463) will decrease coverage by 0.03%.
The diff coverage is 5.74%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #802      +/-   ##
===========================================
- Coverage    10.56%   10.53%   -0.04%     
===========================================
  Files          330      332       +2     
  Lines        76938    77421     +483     
===========================================
+ Hits          8129     8155      +26     
- Misses       68604    69059     +455     
- Partials       205      207       +2     
Impacted Files Coverage Δ
...gn/client/cli/query_special_allocations_balance.go 0.00% <0.00%> (ø)
x/campaign/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/campaign/types/query.pb.go 0.63% <0.54%> (-0.01%) ⬇️
...ampaign/keeper/grpc_special_allocations_balance.go 90.00% <90.00%> (ø)
x/campaign/simulation/store.go 81.08% <0.00%> (-2.03%) ⬇️

Copy link

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have test cases for the two times that CoinsFromTotalSupply() can throw an error in this function.

@lumtis lumtis requested a review from aljo242 May 19, 2022 09:47
@lumtis lumtis merged commit b6b4eaf into develop May 27, 2022
@lumtis lumtis deleted the special-allocations-balance branch May 27, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement queries to returns special allocations with tokens instead of shares
3 participants