-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(campaign
): implement query special-allocations-balance
#802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
fadeev,
ilgooz,
Pantani,
ivanovpetr,
aljo242 and
giunatale
as code owners
May 17, 2022 16:00
Codecov Report
@@ Coverage Diff @@
## develop #802 +/- ##
===========================================
- Coverage 10.56% 10.53% -0.04%
===========================================
Files 330 332 +2
Lines 76938 77421 +483
===========================================
+ Hits 8129 8155 +26
- Misses 68604 69059 +455
- Partials 205 207 +2
|
aljo242
suggested changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have test cases for the two times that CoinsFromTotalSupply()
can throw an error in this function.
Pantani
reviewed
May 26, 2022
Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
special-allocations-balance
get the final token balance for special allocation.This query is to be used by the client to verify the genesis is correctly formatted: