refactor(campaign): MainnetAccountBalanceAll: omit account with empty balance
#803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
fadeev,
ilgooz,
Pantani,
ivanovpetr,
aljo242 and
giunatale
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #803 +/- ##
========================================
Coverage 10.56% 10.56%
========================================
Files 315 315
Lines 73466 73468 +2
========================================
+ Hits 7760 7765 +5
+ Misses 65519 65517 -2
+ Partials 187 186 -1
|
aljo242
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the client would rely on this query to construct the genesis account balances and an account can't have an empty balance in the genesis. This PR modifies
MainnetAccountBalanceAllto omit the mainnet account with an empty balance:Example: if all the shares of the accounts reflect tokens that are not in the total supply of the mainnet