-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launch
): automatically fetch mainnet account balances for query GenesisAccounts
with mainnet
#805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
fadeev,
ilgooz,
Pantani,
ivanovpetr,
aljo242 and
giunatale
as code owners
May 19, 2022 08:43
Codecov Report
@@ Coverage Diff @@
## develop #805 +/- ##
===========================================
+ Coverage 10.50% 10.54% +0.04%
===========================================
Files 332 332
Lines 77711 77755 +44
===========================================
+ Hits 8164 8202 +38
- Misses 69342 69346 +4
- Partials 205 207 +2
|
@Pantani @giunatale @aljo242 please review this one when you can |
aljo242
approved these changes
Jun 1, 2022
…tendermint/spn into launch-genesis-accounts-mainnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same query
GenesisAccount
GenesisAccountAll
can be used to get the genesis account with final balances for mainent.This simplify launching mainnet from the client perspective
The feature can be tested with Ignite CLI:
The genesis contains the account balance calculated from their shares