Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitoringc): fix not found query response for VerifiedClientIds #810

Merged
merged 3 commits into from
May 25, 2022

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented May 25, 2022

No description provided.

lumtis
lumtis previously approved these changes May 25, 2022
@lumtis lumtis self-requested a review May 25, 2022 12:27
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Can we just change the expected error in grpc_verified_client_ids_test.go?

@Pantani Pantani requested a review from lumtis May 25, 2022 14:24
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #810 (0c34904) into develop (2243743) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #810   +/-   ##
========================================
  Coverage    10.56%   10.56%           
========================================
  Files          330      330           
  Lines        76938    76938           
========================================
+ Hits          8128     8129    +1     
+ Misses       68605    68604    -1     
  Partials       205      205           
Impacted Files Coverage Δ
x/monitoringc/keeper/grpc_verified_client_ids.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 83.10% <0.00%> (+0.67%) ⬆️

@lumtis lumtis merged commit 11fb463 into develop May 25, 2022
@lumtis lumtis deleted the fix/not-found-query-return branch May 25, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants