Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): add coordinator address and ID for chain and campaign creation #824

Merged
merged 3 commits into from
May 31, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented May 30, 2022

Add for both EventChainCreated and EventCampaignCreated the address and ID of the coordinator for indexation purpose

@lumtis
Copy link
Contributor Author

lumtis commented May 30, 2022

@jeronimoalbi @ilgooz tell me if you have any comment

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #824 (96176d4) into develop (0cb81a6) will decrease coverage by 0.00%.
The diff coverage is 7.01%.

❗ Current head 96176d4 differs from pull request most recent head cbada78. Consider uploading reports for the commit cbada78 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #824      +/-   ##
===========================================
- Coverage    10.53%   10.52%   -0.01%     
===========================================
  Files          332      332              
  Lines        77421    77533     +112     
===========================================
+ Hits          8157     8163       +6     
- Misses       69058    69164     +106     
  Partials       206      206              
Impacted Files Coverage Δ
x/campaign/types/events.pb.go 0.54% <0.00%> (-0.01%) ⬇️
x/launch/types/events.pb.go 0.49% <0.00%> (-0.02%) ⬇️
x/campaign/keeper/msg_create_campaign.go 86.95% <100.00%> (+0.28%) ⬆️
x/launch/keeper/chain.go 97.45% <100.00%> (+0.11%) ⬆️

@jeronimoalbi
Copy link
Collaborator

@jeronimoalbi @ilgooz tell me if you have any comment

looks good 👍 !

@lumtis lumtis merged commit 7aa6e07 into develop May 31, 2022
@lumtis lumtis deleted the event-add-coord branch May 31, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants