refactor(campaign): remove MsgAddVestingOptions

[aljo242]

Closes #818

[codecov]

Codecov Report

Merging #827 (5e3e0c9) into develop (7833ecf) will increase coverage by 0.03%.
The diff coverage is 6.93%.

@@             Coverage Diff             @@
##           develop     #827      +/-   ##
===========================================
+ Coverage    10.32%   10.35%   +0.03%     
===========================================
  Files          328      322       -6     
  Lines        77189    75344    -1845     
===========================================
- Hits          7968     7802     -166     
+ Misses       69028    67355    -1673     
+ Partials       193      187       -6     

Impacted Files	Coverage Δ
x/campaign/genesis.go	100.00% <ø> (ø)
x/campaign/simulation/simulation.go	0.00% <ø> (ø)
x/campaign/types/events.pb.go	0.54% <ø> (ø)
x/campaign/types/genesis.pb.go	1.58% <0.00%> (+0.16%)	⬆️
x/campaign/types/query.pb.go	0.64% <0.00%> (+0.01%)	⬆️
x/campaign/types/query.pb.gw.go	0.00% <ø> (ø)
x/campaign/types/tx.pb.go	0.58% <0.00%> (+<0.01%)	⬆️
x/campaign/types/vesting.pb.go	2.44% <2.56%> (ø)
x/campaign/types/genesis.go	100.00% <100.00%> (ø)
x/campaign/simulation/store.go	81.08% <0.00%> (-2.03%)	⬇️
... and 1 more

[lumtis]

We can also remove the commented block in x/campaign/handler.go

And we can remove everything related to MainnetVestingAccount
mainnet_vesting_account.proto
cli/query_mainnet_vesting_account.go
keeper/grpc_mainnet_vesting_account.go
keeper/mainnet_vesting_account.go
types/mainnet_vesting_account.go

In the future, if we introduce vouchers for vesting options, this part would be refactored heavily. Therefore, I think it's more beneficial to remove this now

[aljo242]

We can also remove the commented block in x/campaign/handler.go

And we can remove everything related to MainnetVestingAccount mainnet_vesting_account.proto cli/query_mainnet_vesting_account.go keeper/grpc_mainnet_vesting_account.go keeper/mainnet_vesting_account.go types/mainnet_vesting_account.go

In the future, if we introduce vouchers for vesting options, this part would be refactored heavily. Therefore, I think it's more beneficial to remove this now

The build will now fail because ignite-cli imports and uses the MainnetVestingAccount type from our code. We will need to make a PR on their end to remove this.

[lumtis]

Indeed, I didn't know we used mainnet vesting account in the CLI but we can remove every occurrence of it

[lumtis]

@aljo242 I created a PR for remove mainnet vesting account from cli ignite/cli#2549

However, in this PR there is still reference to mainnet vesting accounts in
x/campaign/genesis_test.go
x/campaign/keeper/invariants_test.go

[aljo242]

Code is all merged - just waiting on changes to be made in Ignite CLI

[Pantani]

wrong import sort. You should run make format

[lumtis]

@Pantani I'm waiting for ignite/cli#2566 being merged to complete ignite/cli#2549

Is there anything blocking for ignite/cli#2566?

[Pantani]

@Pantani I'm waiting for ignite-hq/cli#2566 being merged to complete ignite-hq/cli#2549

Is there anything blocking for ignite-hq/cli#2566?

yes, I found some issues, but now the cosmogen is not generating the mint module for the vuex, I'm trying to find the issue

[Pantani]

@Pantani I'm waiting for ignite-hq/cli#2566 being merged to complete ignite-hq/cli#2549

Is there anything blocking for ignite-hq/cli#2566?

merged

[lumtis]

@aljo242 just pushed a fix for invariant test that was still taking Vesting Options into consideration