Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove campaign summary queries #905

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Jul 25, 2022

  • Remove CampaignSummary and CampaignSummaries queries
  • Remove Reward dependency for campaign
  • Remove Count methods for request and genesis validator in launch

@lumtis lumtis linked an issue Jul 25, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #905 (b7a22b0) into develop (1858505) will increase coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #905      +/-   ##
===========================================
+ Coverage    10.42%   10.56%   +0.13%     
===========================================
  Files          330      327       -3     
  Lines        76837    75095    -1742     
===========================================
- Hits          8013     7932      -81     
+ Misses       68634    66977    -1657     
+ Partials       190      186       -4     
Impacted Files Coverage Δ
x/campaign/types/query.pb.go 0.66% <0.00%> (+<0.01%) ⬆️
x/campaign/types/query.pb.gw.go 0.00% <ø> (ø)
x/launch/keeper/genesis_validator.go 100.00% <ø> (+16.07%) ⬆️
x/launch/keeper/request.go 100.00% <ø> (+4.92%) ⬆️
x/campaign/simulation/store.go 84.45% <0.00%> (+2.02%) ⬆️

@lumtis lumtis marked this pull request as ready for review July 25, 2022 09:42
@aljo242 aljo242 merged commit c990134 into develop Jul 25, 2022
@aljo242 aljo242 deleted the refactor/remove-campaign-summary branch July 25, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CampaignSummary and CampaignSummaries
2 participants