fix golangci-lint

Signed-off-by: Keming <[email protected]>
tensorchord · Jan 8, 2025 · fb0a9fa · fb0a9fa
1 parent 91b93bb
commit fb0a9fa
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -3,7 +3,7 @@ linters:
     - bodyclose
     - errcheck
     - errorlint
-    - exportloopref
+    - copyloopvar
     - gofmt
     - goimports
     - gosimple

diff --git a/pkg/lang/ir/v0/compile.go b/pkg/lang/ir/v0/compile.go
@@ -215,7 +215,7 @@ func (g generalGraph) Labels() (map[string]string, error) {
 		})
 	}
 
-	if g.RuntimeExpose != nil && len(g.RuntimeExpose) > 0 {
+	if len(g.RuntimeExpose) > 0 {
 		for _, item := range g.RuntimeExpose {
 			ports = append(ports, servertypes.EnvironmentPort{
 				Name: item.ServiceName,
@@ -256,7 +256,7 @@ func (g generalGraph) ExposedPorts() (map[string]struct{}, error) {
 		ports[fmt.Sprintf("%d/tcp", config.RStudioServerPortInContainer)] = struct{}{}
 	}
 
-	if g.RuntimeExpose != nil && len(g.RuntimeExpose) > 0 {
+	if len(g.RuntimeExpose) > 0 {
 		for _, item := range g.RuntimeExpose {
 			ports[fmt.Sprintf("%d/tcp", item.EnvdPort)] = struct{}{}
 		}

diff --git a/pkg/lang/ir/v1/compile.go b/pkg/lang/ir/v1/compile.go
@@ -232,7 +232,7 @@ func (g generalGraph) Labels() (map[string]string, error) {
 		})
 	}
 
-	if g.RuntimeExpose != nil && len(g.RuntimeExpose) > 0 {
+	if len(g.RuntimeExpose) > 0 {
 		for _, item := range g.RuntimeExpose {
 			ports = append(ports, servertypes.EnvironmentPort{
 				Name: item.ServiceName,
@@ -273,7 +273,7 @@ func (g generalGraph) ExposedPorts() (map[string]struct{}, error) {
 		ports[fmt.Sprintf("%d/tcp", config.RStudioServerPortInContainer)] = struct{}{}
 	}
 
-	if g.RuntimeExpose != nil && len(g.RuntimeExpose) > 0 {
+	if len(g.RuntimeExpose) > 0 {
 		for _, item := range g.RuntimeExpose {
 			ports[fmt.Sprintf("%d/tcp", item.EnvdPort)] = struct{}{}
 		}

diff --git a/pkg/progress/compileui/display.go b/pkg/progress/compileui/display.go
@@ -41,7 +41,7 @@ type generalWriter struct {
 	phase       string
 	trace       *trace
 	doneCh      chan bool
-	repeated     bool
+	repeated    bool
 	result      *Result
 	lineCount   int
 }
@@ -72,7 +72,7 @@ func New(ctx context.Context, out console.File, mode string) (Writer, error) {
 		phase:       "parse build.envd and download/cache dependencies",
 		trace:       t,
 		doneCh:      make(chan bool),
-		repeated:     false,
+		repeated:    false,
 		result: &Result{
 			plugins: make([]*PluginInfo, 0),
 		},

diff --git a/pkg/syncthing/device.go b/pkg/syncthing/device.go
@@ -52,7 +52,7 @@ func ConnectDevices(s1 *Syncthing, s2 *Syncthing) error {
 
 // This method can only be called when the devices are not connected
 func (s *Syncthing) SetDeviceAddress(addr string) (err error) {
-	if s.Config.Devices == nil || len(s.Config.Devices) == 0 {
+	if len(s.Config.Devices) == 0 {
 		return fmt.Errorf("no devices found")
 	}
 	s.DeviceAddress = addr