Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cve): docker & buildkit #1936

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Jan 8, 2025

interface changes:

  • prune match buildx
    • removed keep-storage
    • added max-used-mb, min-free-mb, and reserved-mb

@kemingy kemingy requested review from Copilot and removed request for zwpaper, aseaday and gaocegege January 8, 2025 14:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (13)
  • go.mod: Language not supported
  • pkg/autocomplete/zsh.go: Evaluated as low risk
  • pkg/envd/envdserver.go: Evaluated as low risk
  • pkg/app/image_prune.go: Evaluated as low risk
  • pkg/envd/engine.go: Evaluated as low risk
  • pkg/driver/nerdctl/nerdctl.go: Evaluated as low risk
  • pkg/envd/docker.go: Evaluated as low risk
  • pkg/driver/client.go: Evaluated as low risk
  • pkg/buildkitd/mock/mock.go: Evaluated as low risk
  • pkg/types/envd.go: Evaluated as low risk
  • pkg/builder/build.go: Evaluated as low risk
  • pkg/app/image_prune_test.go: Evaluated as low risk
  • pkg/buildkitd/buildkitd.go: Evaluated as low risk
Comments suppressed due to low confidence (2)

pkg/app/debug_llb.go:170

  • The new implementation within the attr function should be reviewed to ensure it covers all the scenarios previously handled by generateExecNode, such as handling mounts, user, cwd, and env.
return strings.Join(op.Exec.Meta.Args, " "), "box"

pkg/app/prune.go:73

  • Ensure that the new parameters 'max-used-mb', 'min-free-mb', and 'reserved-mb' are covered by tests.
maxUsed := clicontext.Float64("max-used-mb")
@kemingy kemingy merged commit d7ef20d into tensorchord:main Jan 8, 2025
12 checks passed
@kemingy kemingy deleted the bump_docker branch January 8, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant