Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0.9 branch release streategy #1819

Merged
merged 1 commit into from
May 12, 2020

Conversation

seanpmorgan
Copy link
Member

Combines changes from #1760 and #1762

  • Use Github token for Bazel API requests
  • Pin pip to 19.0 during release
  • Test against 2.2.0 stable (still build against 2.1.0 though)

Unblocks #1810

* Use Github token for Bazel API requests
* Pin pip to 19.0 during release
@bhack
Copy link
Contributor

bhack commented May 12, 2020

Ok I think that we need to remove or modify this to support a list tools/update_release_version.sh

@gabrieldemarmiesse
Copy link
Member

Thanks @seanpmorgan !

@gabrieldemarmiesse gabrieldemarmiesse merged commit 2bf8f0a into tensorflow:r0.9 May 12, 2020
@seanpmorgan seanpmorgan deleted the 0.9-update-release branch May 12, 2020 17:21
@gabrieldemarmiesse
Copy link
Member

gabrieldemarmiesse commented May 13, 2020

I think we broke the CI of the 0.9 branch with this pull request. I think it must have been a problem with indentation in the yaml. The tests are not running in the different OSs. I'm just noticing now.

I have the official title of worst reviewer ever.

@seanpmorgan do we forget about the 0.9.2 release? Let's push then for a release of the 0.10 as soon as possible, I don't think there is anything blocking it. It doesn't really matter if #1807 is not merged yet.

@seanpmorgan
Copy link
Member Author

I think we broke the CI of the 0.9 branch with this pull request. I think it must have been a problem with indentation in the yaml. The tests are not running in the different OSs. I'm just noticing now.

I have the official title of worst reviewer ever.

@seanpmorgan do we forget about the 0.9.2 release? Let's push then for a release of the 0.10 as soon as possible, I don't think there is anything blocking it. It doesn't really matter if #1807 is not merged yet.

Yeah I think that's the best course of action. Sorry I missed the CI getting skipped as well. In either case the deprecation warning for custom activations landing on 0.10 is fine since that still gives 2 releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants