This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
Adding GlobalAveragePooling 3D #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
reviewed
Apr 2, 2019
There was a problem hiding this comment.
Could you add some tests in https://github.com/tensorflow/swift-apis/blob/master/Tests/DeepLearningTests/LayerTests.swift?
Sources/DeepLearning/Layer.swift
Outdated
| @@ -1022,7 +1022,7 @@ public struct GlobalAveragePooling1D<Scalar: TensorFlowFloatingPoint>: Layer { | |||
| /// - input: The input to the layer. | |||
| /// - context: The contextual information for the layer application, e.g. the current learning | |||
| /// phase. | |||
| /// - Returns: The output | |||
| /// - Returns: The output | |||
There was a problem hiding this comment.
Add period.
Suggested change
| /// - Returns: The output | |
| /// - Returns: The output. |
Sources/DeepLearning/Layer.swift
Outdated
| /// - input: The input to the layer. | ||
| /// - context: The contextual information for the layer application, e.g. the current learning | ||
| /// phase. | ||
| /// - Returns: The output |
Sources/DeepLearning/Layer.swift
Outdated
| /// - Returns: The output | ||
| @differentiable | ||
| public func applied(to input: Tensor<Scalar>, in _: Context) -> Tensor<Scalar> { | ||
| return input.mean(alongAxes: [1,2,3]).reshaped(to: [input.shape[0], input.shape[4]]) |
There was a problem hiding this comment.
Add a space after each comma.
Suggested change
| return input.mean(alongAxes: [1,2,3]).reshaped(to: [input.shape[0], input.shape[4]]) | |
| return input.mean(alongAxes: [1, 2, 3]).reshaped(to: [input.shape[0], input.shape[4]]) |
|
@rxwei is it okay if i add the tests in another PR? I think most of the conv layers lack a test, So i'll go through them one by one? |
|
Sure. Sounds good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.