Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: add demo Tonic server #4318

Merged
merged 11 commits into from
Nov 12, 2020
Merged

rust: add demo Tonic server #4318

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f3544ed
rust: add `tonic` dependency stack
wchargin Nov 11, 2020
dacd2fe
rust: compile gRPC bindings with Tonic
wchargin Nov 11, 2020
155c40c
rust: add demo Tonic server
wchargin Nov 11, 2020
bb1f37a
[update diffbase]
wchargin Nov 12, 2020
864fd26
[update diffbase]
wchargin Nov 12, 2020
d743728
[update patch]
wchargin Nov 12, 2020
6a5ef83
[update patch]
wchargin Nov 12, 2020
984ad35
[update diffbase]
wchargin Nov 12, 2020
3ef1476
[update patch]
wchargin Nov 12, 2020
395bda0
[update diffbase]
wchargin Nov 12, 2020
50fa124
[update patch]
wchargin Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
171 changes: 3 additions & 168 deletions tensorboard/data/server/demo.pb.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tensorboard/data/server/gen_protos_tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ fn main() -> std::io::Result<()> {
};
tonic_build::configure()
.out_dir(&out_dir)
.format(false) // don't run `rustfmt`; shouldn't be needed to build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah :) I knew something was weird about the generated file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah—I had format(true) (the default) originally, but that only worked
on my machine because I have rustfmt installed; it failed on Travis.
It would be nice for it to be formatted. We could format it pretty
easily if bazelbuild/rules_rust#388 were resolved, or we could copy what
bazelbuild/rules_rust#479 does and do it the hard way. I figured that to
start we could just accept the ugly generated code: we have the Rustdoc
server for normal API usage questions, and you can always run rustfmt
on it locally if you want to look at the implementation.

.compile(
&[
"tensorboard/compat/proto/event.proto",
Expand Down
Loading