-
Notifications
You must be signed in to change notification settings - Fork 74.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PluggableDevice] Always link kernels_experimental c api #60786
[PluggableDevice] Always link kernels_experimental c api #60786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Hi @gbaned can you help to check the PR process? It's approved but the states is still "Assigned Reviewer". |
Hi @Zantares Sorry for the delay, can you please take a look on below internal errors? Thank you! Traceback (most recent call last): |
Seems this internal error is not related to this PR, I have merged the newest master to see if it can be fixed, thanks! |
Hi @penpornk may you reapprove this PR? |
Hi @penpornk Can you please review this PR ? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! Reapproving.
PluggableDevice architecture relies on C APIs to communicate with the TensorFlow binary. To support pluggable device for third party like tensorflow serving, we need add always_link=1 for kernels_experimental.
Signed-off-by: Lu Teng [email protected]