Skip to content

Commit

Permalink
Build node addon before running tests (#7884)
Browse files Browse the repository at this point in the history
Fix a race condition in CI where the tests may be run before the node addon is built.
  • Loading branch information
mattsoulanille authored Jul 31, 2023
1 parent 5974699 commit 93e9af4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions scripts/cloudbuild_tfjs_node_expected.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ steps:
- test-ci
waitFor:
- yarn-tfjs-node
- build-addon-tfjs-node
- lint-tfjs-node
- yarn-common
- yarn-link-package-build
Expand Down
2 changes: 1 addition & 1 deletion tfjs-node-gpu/cloudbuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ steps:
entrypoint: 'yarn'
id: 'test'
args: ['test-ci']
waitFor: ['yarn', 'build-deps', 'lint']
waitFor: ['yarn', 'build-addon', 'build-deps', 'lint']

# CPU / GPU package alignment.
- name: 'gcr.io/learnjs-174218/release'
Expand Down
2 changes: 1 addition & 1 deletion tfjs-node/cloudbuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ steps:
entrypoint: 'yarn'
id: 'test'
args: ['test-ci']
waitFor: ['yarn', 'build-deps', 'lint']
waitFor: ['yarn', 'build-addon', 'build-deps', 'lint']

# CPU / GPU package alignment.
- name: 'gcr.io/learnjs-174218/release'
Expand Down

0 comments on commit 93e9af4

Please sign in to comment.