Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about use of preprocessing layers to getting started notebook #275

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pritamdodeja
Copy link

Summary of change

Getting started notebook was missing information about the possibility of using preprocessing layers, along with some caveats. Additionally, information about the serialization related issues having to do with the use of Lambda layers was also missing. I have added both in this pull request.

Added information about the usage of preprocessing layers to
docs/get_started.ipynb, including caveats for which layers can be used,
and which cannot, along with deserialization issues with Lambda layers.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pindinagesh pindinagesh requested a review from zoyahav May 28, 2022 12:36
@rcrowe-google rcrowe-google requested review from rcrowe-google and removed request for zoyahav October 26, 2022 21:41
Copy link

@rcrowe-google rcrowe-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sorry for the long delay on reviewing this!

"The *preprocessing function* is the most important concept of `tf.Transform`.\n",
"The preprocessing function is a logical description of a transformation of the\n",
"dataset. The preprocessing function accepts and returns a dictionary of tensors,\n",
"where a *tensor* means `Tensor` or `SparseTensor`. There are two kinds of\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be three kinds?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcrowe-google you are right. I will correct this and re-submit. Thank you for reviewing!

@rthadur rthadur self-assigned this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants