-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added information about use of preprocessing layers to getting started notebook #275
base: master
Are you sure you want to change the base?
Added information about use of preprocessing layers to getting started notebook #275
Conversation
Added information about the usage of preprocessing layers to docs/get_started.ipynb, including caveats for which layers can be used, and which cannot, along with deserialization issues with Lambda layers.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very sorry for the long delay on reviewing this!
docs/get_started.ipynb
Outdated
"The *preprocessing function* is the most important concept of `tf.Transform`.\n", | ||
"The preprocessing function is a logical description of a transformation of the\n", | ||
"dataset. The preprocessing function accepts and returns a dictionary of tensors,\n", | ||
"where a *tensor* means `Tensor` or `SparseTensor`. There are two kinds of\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be three kinds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rcrowe-google you are right. I will correct this and re-submit. Thank you for reviewing!
Summary of change
Getting started notebook was missing information about the possibility of using preprocessing layers, along with some caveats. Additionally, information about the serialization related issues having to do with the use of Lambda layers was also missing. I have added both in this pull request.