Move definitions to implementation for core.hpp #17118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blozano-tt
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
cfjchu and
TT-BrianLiu
as code owners
afuller-TT
approved these changes
Jan 26, 2025
ayerofieiev-tt
approved these changes
Jan 27, 2025
williamlyTT
pushed a commit
that referenced
this pull request
Jan 30, 2025
yieldthought
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Build time on single core machine is 2.5 hours.
core.hpp is a header file that is included 462 times, and it consumes 745s of compile time.
There are inline functions in this file, and its not clear to me why.
Defining the definition in every translation unit will have a compile time cost.
If these functions need to be inlined in the binary, the compiler should make that decision automatically (I believe).
Additionally, magic_enum is a very expensive template library, and it is included 462 times transitively.
Move it to Cpp file.
I would like to see if I can start using forward declarations as well in a follow up PR.
What's changed
Remove usage of inline for free functions in ttnn::core namespace.
Add missing includes.
Move singleton instance() method definition to cpp file, along with all other methods.
Move magic_enum inclusion to implementation.
How does compile time change?
This PR fixes this problem (gone)
And decreases the compile time cost of core.hpp by 40%.
Checklist