#0: Fix ttnn shared libs build #17127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankarmanoj-tt
requested review from
cfjchu,
ayerofieiev-tt and
dmakoviichuk-tt
as code owners
ayerofieiev-tt
approved these changes
Jan 29, 2025
| @@ -62,8 +62,9 @@ class type_caster<ttnn::SimpleShape> { | |||
| public: | |||
| PYBIND11_TYPE_CASTER(ttnn::SimpleShape, _("SimpleShape")); | |||
|
|
|||
| bool load(handle src, bool); | |||
| static handle cast(const ttnn::SimpleShape& src, return_value_policy /* policy */, handle /* parent */); | |||
| PYBIND11_EXPORT bool load(handle src, bool); | |||
There was a problem hiding this comment.
Don’t need to export the class itself?
There was a problem hiding this comment.
I tried making the whole namespace visible initially, but that didn't work.
The error I got was that the function was an undefined hidden symbol. Just exporting the function made it work.
williamlyTT
pushed a commit
that referenced
this pull request
Jan 30, 2025
### Problem description Build using `--ttnn-shared-sublibs` was broken ### What's changed Pybind uses hidden visibility, which causes a linker error for functions defined in *.cpp files. Defintions moved to header file. ### Checklist - [ ] Post commit CI [passes](https://github.com/tenstorrent/tt-metal/actions/runs/13003713246)
yieldthought
pushed a commit
that referenced
this pull request
Jan 31, 2025
### Problem description Build using `--ttnn-shared-sublibs` was broken ### What's changed Pybind uses hidden visibility, which causes a linker error for functions defined in *.cpp files. Defintions moved to header file. ### Checklist - [ ] Post commit CI [passes](https://github.com/tenstorrent/tt-metal/actions/runs/13003713246)
nikileshx
pushed a commit
to nikileshx/tt-metal
that referenced
this pull request
Feb 3, 2025
### Problem description Build using `--ttnn-shared-sublibs` was broken ### What's changed Pybind uses hidden visibility, which causes a linker error for functions defined in *.cpp files. Defintions moved to header file. ### Checklist - [ ] Post commit CI [passes](https://github.com/tenstorrent/tt-metal/actions/runs/13003713246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Build using
--ttnn-shared-sublibswas brokenWhat's changed
Pybind uses hidden visibility, which causes a linker error for functions defined in *.cpp files.
Defintions moved to header file.
Checklist