Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17374: Add concurrency group for _produce-data.yaml #17402

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

williamlyTT
Copy link
Contributor

Ticket

17374

Problem description

Produce data jobs get spawned in parallel.
When the jobs all access GH api at once we may encounter rate limiting, causing the jobs to fail.

What's changed

Add concurrency group so that produce data runs in FIFO manner.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@williamlyTT williamlyTT requested a review from a team as a code owner January 30, 2025 22:21
@williamlyTT
Copy link
Contributor Author

williamlyTT commented Jan 30, 2025

https://github.com/tenstorrent/tt-metal/actions/metrics/usage?dateRangeType=DATE_RANGE_TYPE_LAST_30_DAYS&filters=workflow_file_name%3A_produce-data.yaml

We run on average 10 produce-data jobs per hour at 2min each, so we'll most likely have enough headroom to avoid queueing even if I set a concurrency group.

Copy link
Contributor

@blozano-tt blozano-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williamlyTT williamlyTT merged commit db67d1f into main Jan 30, 2025
8 of 9 checks passed
@williamlyTT williamlyTT deleted the williamly/retry-gh-api-downloads branch January 30, 2025 22:34
@williamlyTT williamlyTT restored the williamly/retry-gh-api-downloads branch January 30, 2025 22:46
williamlyTT added a commit that referenced this pull request Jan 30, 2025
williamlyTT added a commit that referenced this pull request Jan 30, 2025
williamlyTT added a commit that referenced this pull request Jan 30, 2025
…l" (#17404)

Reverts #17402

It's cancelling because the group is based on commit hash, not workflow
run
Will fix but reverting first
@williamlyTT
Copy link
Contributor Author

yieldthought pushed a commit that referenced this pull request Jan 31, 2025
### Ticket
[17374](#17374)

### Problem description
Produce data jobs get spawned in parallel.
When the jobs all access GH api at once we may encounter rate limiting,
causing the jobs to fail.

### What's changed
Add concurrency group so that produce data runs in FIFO manner.

### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
yieldthought pushed a commit that referenced this pull request Jan 31, 2025
…l" (#17404)

Reverts #17402

It's cancelling because the group is based on commit hash, not workflow
run
Will fix but reverting first
@afuller-TT
Copy link
Contributor

https://taurit.pl/github-canceling-since-a-higher-priority-waiting-request-exists/ :(

GHA strikes again.

nikileshx pushed a commit to nikileshx/tt-metal that referenced this pull request Feb 3, 2025
…yaml (tenstorrent#17402)

### Ticket
[17374](tenstorrent#17374)

### Problem description
Produce data jobs get spawned in parallel.
When the jobs all access GH api at once we may encounter rate limiting,
causing the jobs to fail.

### What's changed
Add concurrency group so that produce data runs in FIFO manner.

### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
nikileshx pushed a commit to nikileshx/tt-metal that referenced this pull request Feb 3, 2025
…ce-data.yaml" (tenstorrent#17404)

Reverts tenstorrent#17402

It's cancelling because the group is based on commit hash, not workflow
run
Will fix but reverting first
@williamlyTT williamlyTT deleted the williamly/retry-gh-api-downloads branch February 6, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants