-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#17374: Add concurrency group for _produce-data.yaml #17402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run on average 10 produce-data jobs per hour at 2min each, so we'll most likely have enough headroom to avoid queueing even if I set a concurrency group. |
Call it the workflow name
afuller-TT
approved these changes
Jan 30, 2025
blozano-tt
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
yieldthought
pushed a commit
that referenced
this pull request
Jan 31, 2025
### Ticket [17374](#17374) ### Problem description Produce data jobs get spawned in parallel. When the jobs all access GH api at once we may encounter rate limiting, causing the jobs to fail. ### What's changed Add concurrency group so that produce data runs in FIFO manner. ### Checklist - [ ] Post commit CI passes - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
GHA strikes again. |
nikileshx
pushed a commit
to nikileshx/tt-metal
that referenced
this pull request
Feb 3, 2025
…yaml (tenstorrent#17402) ### Ticket [17374](tenstorrent#17374) ### Problem description Produce data jobs get spawned in parallel. When the jobs all access GH api at once we may encounter rate limiting, causing the jobs to fail. ### What's changed Add concurrency group so that produce data runs in FIFO manner. ### Checklist - [ ] Post commit CI passes - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
nikileshx
pushed a commit
to nikileshx/tt-metal
that referenced
this pull request
Feb 3, 2025
…ce-data.yaml" (tenstorrent#17404) Reverts tenstorrent#17402 It's cancelling because the group is based on commit hash, not workflow run Will fix but reverting first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
17374
Problem description
Produce data jobs get spawned in parallel.
When the jobs all access GH api at once we may encounter rate limiting, causing the jobs to fail.
What's changed
Add concurrency group so that produce data runs in FIFO manner.
Checklist