Add folding for ttir.typecast op #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanzoorTT
requested review from
sdjordjevicTT,
nsmithtt,
rpavlovicTT,
svuckovicTT,
mtopalovicTT,
mrakitaTT,
nobradovictt and
jserbedzijaTT
as code owners
mmanzoorTT
force-pushed
the
mmanzoor/typecast-fold
branch
4 times, most recently
from
1edec60 to
cc9872f
Compare
mmanzoorTT
force-pushed
the
mmanzoor/typecast-fold
branch
from
cc9872f to
6a2bcaf
Compare
LPanosTT
reviewed
Dec 11, 2024
azecevicTT
approved these changes
Dec 11, 2024
| // CHECK-LABEL: func.func @cast_fold_add | ||
| // CHECK-NOT: typecast | ||
| // CHECK: ttnn.add | ||
| // CHECK-NOT: typecast |
There was a problem hiding this comment.
Just curious, did you add this second CHECK-NOT to confirm that no typecast will be inserted by some other pass in the pipeline, and even if it gets inserted it will be folded?
There was a problem hiding this comment.
I added to second CHECK-NOT to verify that we don't have any typecast op in the entire graph (either before or after ttnn.add op). I see your point that it causes more confusion and some other optimization may add another typecast op in future. So I have removed the second CHECK-NOT statement.
LPanosTT
approved these changes
Dec 11, 2024
uazizTT
approved these changes
Dec 11, 2024
mmanzoorTT
force-pushed
the
mmanzoor/typecast-fold
branch
from
6a2bcaf to
6ee5109
Compare
mmanzoorTT
force-pushed
the
mmanzoor/typecast-fold
branch
from
6ee5109 to
20bed85
Compare
azecevicTT
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.