Remove maxpool2d preshard workaround #2134
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPanosTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
LPanosTT
force-pushed
the
lpanos/remove_maxpool2d_preshard
branch
from
588581e to
3a67d6d
Compare
LPanosTT
force-pushed
the
lpanos/remove_maxpool2d_preshard
branch
from
3a67d6d to
80d6a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#855
Problem description
We currently pre-shard the input to ttnn::max_pool2d in the runtime.
What's changed
I've removed this workaround since this is taken care of within the ttnn::max_pool2d op.