Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated glam to 0.21. #5

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Updated glam to 0.21. #5

merged 4 commits into from
Jun 30, 2022

Conversation

CGMossa
Copy link
Contributor

@CGMossa CGMossa commented Jun 30, 2022 •
edited
Loading

Fixes #4.

@tim-blackbird
Copy link
Contributor

This will bump the MSRV to 1.58.1.

teoxoy
teoxoy requested changes Jun 30, 2022
View reviewed changes
Copy link
Owner

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few suggestions.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
CGMossa and others added 2 commits June 30, 2022 20:55
@CGMossa @teoxoy
Update Cargo.toml
f32445a 
Co-authored-by: Teodor Tanasoaia <[email protected]>
@CGMossa @teoxoy
Update Cargo.toml
05fb05b 
Co-authored-by: Teodor Tanasoaia <[email protected]>
@CGMossa
Copy link
Contributor Author

CGMossa commented Jun 30, 2022

Sure. num-traits feature was already there. But maybe that is no longer needed.

@CGMossa CGMossa requested a review from teoxoy June 30, 2022 18:57
teoxoy
teoxoy approved these changes Jun 30, 2022
View reviewed changes
Copy link
Owner

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@teoxoy teoxoy merged commit 59ad0e0 into teoxoy:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update glam to 0.21
3 participants
@CGMossa @tim-blackbird @teoxoy