fix for XRPLF#25

tequdev · Feb 20, 2023 · a264120 · a264120
1 parent b75b9f2
commit a264120
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/src/ripple/app/hook/impl/applyHook.cpp b/src/ripple/app/hook/impl/applyHook.cpp
@@ -3246,8 +3246,6 @@ DEFINE_HOOK_FUNCTION(
         return EMISSION_FAILURE;
     }
 
-    hookCtx.result.emittedTxn.push(tpTrans);
-
     auto const& txID =
         tpTrans->getID();
 
@@ -3257,11 +3255,22 @@ DEFINE_HOOK_FUNCTION(
     if (NOT_IN_BOUNDS(write_ptr, txID.size(), memory_length))
         return OUT_OF_BOUNDS;
 
-    WRITE_WASM_MEMORY_AND_RETURN(
-        write_ptr, txID.size(),
-        txID.data(), txID.size(),
-        memory, memory_length);
 
+
+    auto const write_txid = [&]() -> int64_t
+    { 
+        WRITE_WASM_MEMORY_AND_RETURN(
+            write_ptr, txID.size(),
+            txID.data(), txID.size(),
+            memory, memory_length);
+    };
+
+    int64_t result = write_txid();
+
+    if (result == 32)
+        hookCtx.result.emittedTxn.push(tpTrans);
+
+    return result;
     HOOK_TEARDOWN();
 }