enhance(main/cmus): Add AAudio output plugin #21069
Conversation
|
We'd likely prefer to wait for the above mentioned PR in
See "Don't ship WIP" for a more detailed breakdown. |
|
I'm one of the upstream maintainers. The next release of cmus is unlikely to be for a very long time (releases usually have at least a year between them since only one person can do them and they aren't usually available). I figure since this is Android-only and Termux is the only way to run cmus on Android, it's a similar situation as the aaudio/sles PulseAudio sinks, where it's mostly done as a patch in Termux. I'll be keeping this PR marked as a draft for at least a few days until I've thoroughly tested the plugin (I believe it's stable now, but just to be sure). |
|
Ah okay thank you that clears things up. |
|
Do you mind if I do a review pass while the PR is still in the draft stage? |
|
Yeah, feel free to do a review. I just got the package build to work, and I've already been testing the plugin for a few days, so the code's pretty much final. |
packages/cmus/aaudio.patch
Outdated
| + { NULL }, | ||
| +}; | ||
| + | ||
| +const int op_priority = -3; // higher priority than pulse (-2) |
There was a problem hiding this comment.
I set this to be a higher priority than pulse since it should almost always be the better option if it's supported.
Another option could be to split the pulseaudio plugin into a subpackage, with the aaudio plugin having a lower priority.
There was a problem hiding this comment.
We should be able to do something along the lines of what the bash package does.
termux-packages/packages/bash/build.sh
Lines 39 to 78 in 58ee4ec
Although, since this is a single patch we're not going to need the whole array shenanigans.
pgaskin
force-pushed
the
cmus-aaudio
branch
3 times, most recently
from
de4ce69 to
03e9e67
Compare
The build failure is unrelated to this change (it was fine when I tested it just now). |
|
The build failure is caused by |
Please wait for #21038 |
|
No idea 😔 |
Support native audio on Android 8.1 and later. - Better battery life. - Configurable latency. - Configurable capture policy. - Configurable sharing mode. - Configurable spatialization. - Full multi-channel audio support. - Supports `pause_on_output_change`. Also includes fix for pause_on_output change with softvol enabled since aaudio doesn't have volume control. cmus/cmus#1346 cmus/cmus#1353
|
@pgaskin thank you for your contribution. |
Support native audio on Android 8.1 and later.
pause_on_output_change.cmus/cmus#1346
cmus/cmus@3880d9d