Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable,bump(main/deno): 2.1.2 #22379

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

enable,bump(main/deno): 2.1.2 #22379

wants to merge 7 commits into from

Conversation

mbekkomo
Copy link
Contributor

@mbekkomo mbekkomo commented Nov 24, 2024 •
edited
Loading

WIP

@mbekkomo mbekkomo force-pushed the enable-deno branch 16 times, most recently from 159cd28 to 8d8e584 Compare November 25, 2024 11:03
@mbekkomo
Copy link
Contributor Author

mbekkomo commented Nov 25, 2024 •
edited
Loading

Ninja tries to link libclang_rt which is not possible to link, and there's no way to disable it nor replace it with libgcc.

Waiting for denoland/rusty_v8#1662.

@licy183
Copy link
Member

licy183 commented Nov 25, 2024

The linkage should comes from chromium or v8, not really related to rusty_v8. I'll have a look this night or tomorrow.

@mbekkomo
Copy link
Contributor Author

The linkage should comes from chromium or v8, not really related to rusty_v8. I'll have a look this night or tomorrow.

I can take a look at it later. Seems it comes from V8's BUILD.gn.

@licy183 licy183 force-pushed the enable-deno branch 5 times, most recently from 3784696 to 8f438c7 Compare November 25, 2024 15:33
@mbekkomo
Copy link
Contributor Author

TODO: Patch src/binding.cc regarding static assertation error (probably bad architecture assumption)

@mbekkomo mbekkomo force-pushed the enable-deno branch 3 times, most recently from d85fbbe to d850d18 Compare November 27, 2024 12:08
@mbekkomo
Copy link
Contributor Author

aarch64 build might failed because of snapshot being compiled for x86_64.

@mbekkomo mbekkomo changed the title enable,bump(main/deno): 2.1.1 enable,bump(main/deno): 2.1.2 Nov 30, 2024
@mbekkomo
Copy link
Contributor Author

Cargo built x86_64 deno on aarch64 build, thus ld: error: /data/data/com.termux/files/usr/lib/libsqlite3.so is incompatible with elf64-x86-64 error shows up
Need to patch this one

@mbekkomo mbekkomo force-pushed the enable-deno branch 15 times, most recently from bbad4fc to de462bc Compare December 3, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 will be requested when the pull request is marked ready for review Grimler91 is a code owner

@TomJo2000 TomJo2000 Awaiting requested review from TomJo2000 TomJo2000 will be requested when the pull request is marked ready for review TomJo2000 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbekkomo @licy183 @truboxl