Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.json for npm support #46

Merged
merged 3 commits into from
Aug 11, 2016
Merged

Conversation

lutangar
Copy link
Contributor

@lutangar lutangar commented Jun 3, 2016

As requested in #37, this add the package.json for npm support.
This also fix usage with import/require synthax, otherwise this PR would be useless:
ES6:

import porthole from 'porthole';

RequireJs:

var porthole = require("porthole");

What's left to you:
Choose a version number that suits you for the package (1.0.0 as for now) and I'll change it in this PR.

Once merged, you're good to publish this on your own:

npm adduser
npm publish

more infos here https://docs.npmjs.com/getting-started/publishing-npm-packages

Cheers.

@indraneel
Copy link

indraneel commented Jun 16, 2016

@ternarylabs any timeline on this being merged? Would love NPM support!

@ismriv
Copy link

ismriv commented Jun 20, 2016

Same here. This is blocking me from using it - don't really want to copy & paste the module :)

@justinanastos
Copy link

I've been using this in prod for a few weeks with no issues. Can you merge this in or add @lutangar as a collaborator?

@justinanastos
Copy link

@ternarylabs Can you please merge this PR?

@georges georges merged commit d3dcc86 into ternarylabs:master Aug 11, 2016
@indraneel
Copy link

indraneel commented Aug 11, 2016

thanks @georges!

@georges
Copy link
Member

georges commented Aug 11, 2016

ah, looks like a (unrelated) porthole package already exists on npmjs

https://www.npmjs.com/package/porthole

any suggestion on how to best handle this?

@lutangar
Copy link
Contributor Author

@georges you might consider using a scope like @ternarylabs/porthole see https://docs.npmjs.com/misc/scope
Or just choose another package name of your liking.

In any case you'll have to change the name used in the package.json.

@jonhallur
Copy link

Is it on npm yet ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants