Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] v0.5.0 genesis migration does not ensure deterministic result #535

Closed
yun-yeo opened this issue Aug 17, 2021 · 0 comments · Fixed by #536
Closed

[BUG] v0.5.0 genesis migration does not ensure deterministic result #535

yun-yeo opened this issue Aug 17, 2021 · 0 comments · Fixed by #536
Assignees
@yun-yeo
Labels
bug Something isn't working
Milestone
Columbus-5

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Aug 17, 2021

Describe the bug
golang does not give deterministic result for map iteration https://blog.golang.org/maps#TOC_7.

so we need to sort the array at v0.5.0 genesis migration process.

To Reproduce
migrate the exported genesis and check the checksum of result

Context & versions
v0.5.0

(if applicable) suggested solution
Do sort the result array with map key.
@yun-yeo yun-yeo added the bug Something isn't working label Aug 17, 2021
@yun-yeo yun-yeo self-assigned this Aug 17, 2021
@yun-yeo yun-yeo added this to the Columbus-5 milestone Aug 17, 2021
@yun-yeo yun-yeo mentioned this issue Aug 17, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yun-yeo yun-yeo

Labels
bug Something isn't working
Projects
None yet
Milestone
Columbus-5
Development

Successfully merging a pull request may close this issue.

[Bugfix] sort migrated map array to get deterministic result terra-money/classic-core
1 participant
@yun-yeo