Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] sort migrated map array to get deterministic result #536

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Aug 17, 2021

Summary of changes

close #535

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added bug Something isn't working columbus-5 labels Aug 17, 2021
@yun-yeo yun-yeo added this to the Columbus-5 milestone Aug 17, 2021
@yun-yeo yun-yeo requested a review from hanjukim August 17, 2021 03:19
@yun-yeo yun-yeo self-assigned this Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@d6037b9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage        ?   44.88%           
=======================================
  Files           ?      118           
  Lines           ?     6829           
  Branches        ?        0           
=======================================
  Hits            ?     3065           
  Misses          ?     3527           
  Partials        ?      237           

hanjukim
hanjukim previously approved these changes Aug 17, 2021
@yun-yeo yun-yeo merged commit 7ed34ed into main Aug 17, 2021
@hanjukim hanjukim deleted the bugfix/deterministic-genesis-migration branch August 27, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] v0.5.0 genesis migration does not ensure deterministic result
2 participants