Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Remove golangci-lint hash verification #333

Merged
merged 1 commit into from
Mar 24, 2020
Merged

[Bugfix] Remove golangci-lint hash verification #333

merged 1 commit into from
Mar 24, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 23, 2020 •
edited by dokwon
Loading

Summary of changes

close #332

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added the devtools devtool related update label Mar 23, 2020
@yun-yeo yun-yeo self-assigned this Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020 •
edited
Loading

Codecov Report

Merging #333 into develop will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #333   +/-   ##
========================================
  Coverage    72.93%   72.93%           
========================================
  Files           73       73           
  Lines         3100     3100           
========================================
  Hits          2261     2261           
  Misses         732      732           
  Partials       107      107

@dokwon dokwon self-requested a review March 23, 2020 07:26
dokwon
dokwon approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokwon dokwon merged commit 137e367 into develop Mar 24, 2020
@hanjukim hanjukim deleted the feature/remove-lint-hash-check branch June 29, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokwon dokwon dokwon approved these changes

Assignees

@yun-yeo yun-yeo

Labels
devtools devtool related update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] golangci-lint hash sum check error
2 participants
@yun-yeo @dokwon