Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update docker script and circleci to automatically upload core image #334

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 25, 2020

Summary of changes

  • remove unused part in Makefile
  • change the name of docker image on the docker script
  • change circleci to upload image to hub

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from dokwon March 25, 2020 08:11
@yun-yeo yun-yeo self-assigned this Mar 25, 2020
@yun-yeo yun-yeo force-pushed the feature/docker-script-update branch from a017831 to 0cc5141 Compare March 25, 2020 08:33
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #334 into develop will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #334   +/-   ##
========================================
  Coverage    73.14%   73.14%           
========================================
  Files           73       73           
  Lines         3128     3128           
========================================
  Hits          2288     2288           
  Misses         733      733           
  Partials       107      107           

@yun-yeo yun-yeo changed the title [Feature] Update docker script and circleci to automatically upload it [Feature] Update docker script and circleci to automatically upload core image Mar 25, 2020
@dokwon dokwon merged commit 1406f57 into develop Mar 25, 2020
@dokwon dokwon deleted the feature/docker-script-update branch March 25, 2020 10:08
tuky191 pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants